-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Make empty dictionary and set literals use the singleton #22527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please benchmark |
@swift-ci please benchmark |
@swift-ci please test |
Build failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extremely approved!
@swift-ci please benchmark |
@swift-ci please benchmark |
@swift-ci please test |
Build failed |
there should be a facepalm GitHub reaction... |
@swift-ci please benchmark |
Build failed |
Performance: -O
Code size: -O
Performance: -Osize
Code size: -Osize
Performance: -Onone
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
@swift-ci please smoke test and merge |
1 similar comment
@swift-ci please smoke test and merge |
@swift-ci please smoke test and merge |
1 similar comment
@swift-ci please smoke test and merge |
rdar://problem/34740754 let foo: [Int: String] = [:] allocates storage for empty dictionary