[ParseableInterface] Fix failing to build a module when the importing file has errors. #22550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
… file has errors. We were checking the parent invocation's DiagnosticEnginer rather than the subinstance's to determine if there were any errors building the module, which meant we would fail to load the module if there were errors prior to the import statement in the importing file. This also meant code completion would fail to load the module, because it always emits a bogus error in order to mark the AST as erroneous so that different parts of the compiler (e.g. the verifier) have less strict assumptions. rdar://problem/43906499
nathawes
force-pushed
the
code-complete-parseable-interface
branch
from
cfe3894 to
e146630
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test OS X Platform |
|
Build failed |
|
@swift-ci please test OS X |
|
Build failed |
|
OSX failure was unrelated (a SwiftSyntax issue Argyrios has since fixed) @swift-ci please test OS X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #22476 again because it had to be reverted due to a test failure. This updates the code completion test to use %target-swift-ide-test rather than plain %swift-ide-test.
rdar://problem/43906499 (original issue)
Resolves rdar://problem/47975126 (test failure)