[5.0][DebuggerSupport] Unbreak closures in the expression parser. #22572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dcci
commented
Feb 13, 2019
dcci
commented
- Explanation: A previous commit regressed closures in the debugger, we now leave an unresolved identifier for the debugger to fill in.
- Issue: rdar://problem/47982630
- Scope: Affects only debugger support, despite being a change in parsing, so only lldb will be affected.
- Risk: Low
- Testing: Added compiler regression tests
- Reviewed by: @jrose-apple
added 2 commits
February 12, 2019 17:48
The new trick is that of leavign an unresolved identifier for the expression parser to fill in. <rdar://problem/47982630>
|
@swift-ci please test |
dcci
changed the title
bob-wilson
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.