[CMake] StandaloneOverlay: set components before including apinotes/ #22592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Aargh, this isn't quite right—now it's a part of every overlay build instead of just Platform. |
Otherwise, we'll think we don't need to install the API notes. No test because this configuration isn't (yet) tested publicly anywhere, but it is being tested within Apple.
jrose-apple
force-pushed
the
cmake-me-a-match
branch
from
989abc4 to
4e7116a
Compare
|
@swift-ci please test |
|
Build failed |
Rostepher
approved these changes
Feb 13, 2019
|
Build failed |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Feb 14, 2019
…wiftlang#22592) Otherwise, we'll think we don't need to install the API notes. No test because this configuration isn't (yet) tested publicly anywhere, but it is being tested within Apple. (cherry picked from commit bc35b34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we'll think we don't need to install the API notes. Fix-up for #21690.
No test because this configuration isn't (yet) tested publicly anywhere, but it is being tested within Apple.