[NFC] Move selector family logic to ObjCSelector #22605
Merged
+97
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SILFunctionType has some logic which examines a selector and decides if it belongs to one of Objective-C’s special “method families”, like -alloc* and -copy*, which need to return a retained pointer instead of an autoreleased one. This change extracts most of that logic into SwiftAST as ObjCSelector::getSelectorFamily(), while leaving details specific to SIL’s use of it behind.
|
@swift-ci please smoke test |
gottesmm
reviewed
Feb 14, 2019
Matches the new type name, ObjCSelectorFamily.
|
@swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
+1! LGTM! |
|
@swift-ci please test macOS platform |
|
Build failed |
|
Joe force-merged a fix for those test failures in #22650. Once more with feeling! |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILFunctionType has some logic which examines a selector and decides if it belongs to one of Objective-C’s special “method families”, like
-alloc*and-copy*, which need to return a retained object instead of an autoreleased one. This change extracts most of that logic into SwiftAST asObjCSelector::getSelectorFamily(), while leaving details specific to SIL’s use of it behind.