Skip to content

[Serialization] Break up getDeclCheckedImpl into a helper class #22610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 16, 2019
Merged

[Serialization] Break up getDeclCheckedImpl into a helper class #22610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3273f06
[Serialization] Pull decl deserialization out to a helper class
jrose-apple Feb 8, 2019
b5a86cf
[Serialization] Move decl attribute deserialization into new helper
jrose-apple Feb 12, 2019
e540874
[Serialization] Move one case in getDeclCheckedImpl out of line
jrose-apple Feb 13, 2019
8c06223
[Serialization] Make ASTDeserializer stateful, and use that state
jrose-apple Feb 13, 2019
9f80d71
[Serialization] Move various RAII-based setup into DeclDeserializer
jrose-apple Feb 14, 2019
83586c7
[Serialization] Move helper lambda into DeclDeserializer
jrose-apple Feb 14, 2019
855ad2c
[Serialization] Move all the decl layouts into DeclDeserializer
jrose-apple Feb 14, 2019
ec95e68
[Serialization] Collapse one level of helper function I didn't need
jrose-apple Feb 14, 2019
b577838
[Serialization] Collapse prefix/postfix operator deserialization
jrose-apple Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions include/swift/Serialization/ModuleFile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ class ModuleFile
: public LazyMemberLoader,
public LazyConformanceLoader {
friend class SerializedASTFile;
friend class DeclDeserializer;
friend class SILDeserializer;
using Status = serialization::Status;
using TypeID = serialization::TypeID;
Expand Down Expand Up @@ -526,10 +527,6 @@ class ModuleFile
std::unique_ptr<SerializedDeclMembersTable>
readDeclMembersTable(ArrayRef<uint64_t> fields, StringRef blobData);

/// Main logic of getDeclChecked.
llvm::Expected<Decl *>
getDeclCheckedImpl(serialization::DeclID DID);

/// Reads the index block, which contains global tables.
///
/// Returns false if there was an error.
Expand Down
Loading