Skip to content

Don't prompt for credentials in update_checkout #22619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2019

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Feb 14, 2019

The script is not supposed to be interactive, so it's OK to just fail if
it's unable to authenticate the user.

@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

@swift-ci Please smoke test

@moiseev moiseev force-pushed the update-checkout-no-prompt branch from cc595e0 to 6a7fe62 Compare February 14, 2019 19:13
@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

@swift-ci Please smoke test

The script is not supposed to be interactive, so it's OK to just fail if
it's unable to authenticate the user.
@moiseev moiseev force-pushed the update-checkout-no-prompt branch from 6a7fe62 to 1294098 Compare February 14, 2019 21:02
@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor

I think you need an env in there for portability.

@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

@jrose-apple you mean env GIT_TERMINAL_PROMPT=0 git?

@jrose-apple
Copy link
Contributor

Yep, that's all. I think, anyway.

@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

Done. Won't hurt =)

@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

@swift-ci Please smoke test

@moiseev moiseev force-pushed the update-checkout-no-prompt branch from e808df9 to 8f1c70c Compare February 14, 2019 22:40
@moiseev
Copy link
Contributor Author

moiseev commented Feb 14, 2019

@swift-ci Please smoke test

@moiseev moiseev merged commit 73f2008 into swiftlang:master Feb 15, 2019
@moiseev moiseev deleted the update-checkout-no-prompt branch February 15, 2019 01:11
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants