[Sema] NFC: refactor coerceToType() to use switch statments #22681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current series of "unrelated" `if` statements makes understanding and updating this function harder than necessary. By using two `switch` statements, we can avoid these problems and as a bonus, generate more efficient code gen.
|
@swift-ci please smoke test |
|
Overall, looks good. You're absolutely right that this is a twisty piece of work - enough that I suspect tightening things up like this may have closed off a few previously-accessible codepaths. Once the smoke tests pass, I'd sleep better at night if you ran the full tests and the compatibility suite ✨ |
|
@swift-ci please smoke test linux |
1 similar comment
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current series of "unrelated"
ifstatements makes understanding and updating this function harder than necessary. By using twoswitchstatements, we can avoid these problems and as a bonus, generate more efficient code gen.