Skip to content

[benchmark] Janitor Duty: Sweep II #22690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2019
Merged

[benchmark] Janitor Duty: Sweep II #22690

merged 3 commits into from
Feb 20, 2019

Conversation

palimondo
Copy link
Contributor

Some more benchmark cleanup...

@palimondo
[benchmark] DictionaryGroupOfObjects Legacy Factor
bf69971
@palimondo
[benchmark] DictionaryCompactMapValues Setup Overhead
2704a3e 
Refactored to extract setup overhead. Input refference dictionaries are extracted to lazily initialized constants (only first sample includes the overhead, so I’m also skipping the `setUpFunction` with `blackHole`).
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci

This comment has been minimized.

Sign in to view
@palimondo palimondo changed the title [WIP] Janitor Duty: Sweep II [benchmark] Janitor Duty: Sweep II Feb 18, 2019
@palimondo palimondo requested a review from eeckstein February 18, 2019 22:56
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@eeckstein please review 🙏

@swift-ci

This comment has been minimized.

Sign in to view
@palimondo
Copy link
Contributor Author

palimondo commented Feb 19, 2019 •
edited
Loading

I've backed out the DictionaryOfAnyHashableStrings changes, because even though I have found good legacyFactors, there are still issues with setup overhead… @eeckstein do you have any insights what might be causing that? See #20067 (comment)

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci

This comment has been minimized.

Sign in to view
eeckstein
eeckstein requested changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically lgtm. See my comments.

@palimondo
[benchmark] DictionaryCompactMapValues tweeks
311ddce 
Extracted run functions and added setUpFunctions.
@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test os x platform

1 similar comment
@palimondo
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@palimondo
Copy link
Contributor Author

palimondo commented Feb 20, 2019 •
edited
Loading

@swift-ci 🤷‍♂️😤🤯

@swift-ci
Copy link
Contributor

Performance: -O

TEST OLD NEW DELTA RATIO
Improvement
DictionaryGroup 244 228 -6.6% 1.07x (?)

Code size: -O

TEST OLD NEW DELTA RATIO
Improvement
DictionaryCompactMapValues.o 18673 17400 -6.8% 1.07x

Code size: -Osize

TEST OLD NEW DELTA RATIO
Regression
DictionaryCompactMapValues.o 12133 13605 +12.1% 0.89x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview 
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@palimondo palimondo merged commit fae040a into swiftlang:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palimondo @swift-ci @eeckstein