Skip to content

[5.0][String] Naturalize Character #22696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[5.0][String] Naturalize Character #22696

wants to merge 1 commit into from

Conversation

milseman
Copy link
Member

@milseman milseman commented Feb 18, 2019 •
edited
Loading

Cherry-pick of #22663

  • Explanation: This change establishes an invariant (useful for later) that Characters are never backed by lazily-bridged NSStrings or other shared strings. They're either small or in native form.
  • Issue: rdar://problem/48212434 https://bugs.swift.org/browse/SR-9935
  • Scope: Affects the behavior of the inline_always initializer on Character taking a String if passed a non-native String. This is a very rare, but possible, scenario.
  • Risk: Low
  • Testing: Added stdlib regression tests
  • Reviewed by: @lorentey

@milseman
[String] Naturalize Character
1b8a815 
Characters should always be native, and never shared.
@milseman milseman requested a review from a team as a code owner February 18, 2019 22:52
@milseman milseman requested a review from lorentey February 18, 2019 22:52
@milseman
Copy link
Member Author

@swift-ci please test

lorentey
lorentey approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1b8a815

@milseman
Copy link
Member Author

All I see is 18:03:52 1/1 Test #1: TestFoundation ...................***Exception: SegFault 24.41 sec.

@swift-ci please test Linux Platform

@milseman
Copy link
Member Author

NTBF

@milseman milseman closed this Feb 22, 2019
@milseman milseman deleted the 5_0_indigenous_characters branch February 22, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milseman @swift-ci @lorentey