Skip to content

[benchmark] Janitor Duty: Sweep III #22721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2019

Conversation

palimondo
Copy link
Contributor

Clean up setup overhead in few Dictionary benchmarks.

@palimondo palimondo requested a review from eeckstein February 19, 2019 21:43
@palimondo palimondo force-pushed the within-cells-interlinked branch from 13dc254 to aa977ad Compare February 19, 2019 22:51
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

!!! Couldn't read commit file !!!

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@palimondo
Copy link
Contributor Author

@swift-ci please clean smoke test os x platform

@swift-ci

This comment has been minimized.

@swiftlang swiftlang deleted a comment from swift-ci Feb 20, 2019
@palimondo
Copy link
Contributor Author

palimondo commented Feb 20, 2019

@eeckstein: 😕 Should I re-adjust the DictionarySwapAtOfObjects legacyFactor.

@palimondo palimondo force-pushed the within-cells-interlinked branch from 3a0ae9b to 6eb85e4 Compare February 20, 2019 07:01
@swiftlang swiftlang deleted a comment from swift-ci Feb 20, 2019
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@swift-ci

This comment has been minimized.

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

1 similar comment
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

Code size: -O

TEST OLD NEW DELTA RATIO
Regression
DictionaryRemove.o 14456 15848 +9.6% 0.91x
Improvement
DictionarySwap.o 21700 21330 -1.7% 1.02x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
NopDeinit 45000 48700 +8.2% 0.92x (?)

Code size: -Osize

TEST OLD NEW DELTA RATIO
Regression
DictionaryRemove.o 9741 11227 +15.3% 0.87x

Performance: -Onone

TEST OLD NEW DELTA RATIO
Regression
DictionarySwapAt 3584 3864 +7.8% 0.93x (?)
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test Linux platform

@palimondo palimondo merged commit 0a49ba8 into swiftlang:master Feb 20, 2019
@palimondo palimondo deleted the within-cells-interlinked branch May 6, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants