Skip to content

[Preset] Add corelibs foundation presets (SR-9950) #22771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2019
Merged

[Preset] Add corelibs foundation presets (SR-9950) #22771

merged 2 commits into from
Feb 21, 2019

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal shahmishal requested a review from millenomi February 21, 2019 01:36
millenomi
millenomi reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@millenomi millenomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mixin eg the relevant parts of buildbot_incremental so that we build like the apple/swift repository does?

@shahmishal
Copy link
Member Author

@swift-ci smoke test

@millenomi
Copy link
Contributor

Looks good.

@shahmishal
Copy link
Member Author

@swift-ci smoke test Linux

@shahmishal shahmishal merged commit 13d593d into master Feb 21, 2019
@shahmishal shahmishal deleted the shahmishal/pr-corelibs-foundation-preset branch February 26, 2019 02:33
@shahmishal shahmishal mentioned this pull request Feb 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millenomi millenomi millenomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahmishal @millenomi