Sema: Fix inconsistent behavior with SE-0110-related compatibility hack #22783
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back when SE-0110 was implemented we decided that passing a function value taking multiple parameters would be allowed where a function value taking a single tuple argument was expected. Due to quirks in the old function type representation, the "splat" in the other direction sometimes worked too. When we redid the function type representation we added a simulation of the old quirk for -swift-version 4 mode. However this simulation was itself problematic because it only worked when the function value being passed was a non-overloaded declaration reference. Slightly broaden the hack to the overloaded case, to prevent user confusion when adding or removing overloads.
xedin
reviewed
Feb 21, 2019
There was a problem hiding this comment.
Thank you! Maybe you want I'd like to take a look at https://bugs.swift.org/browse/SR-9954 while you are at it? :)
|
Wrong JIRA, trying to find the one I really wanted to mention... |
|
This one - https://bugs.swift.org/browse/SR-9860 |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when SE-0110 was implemented we decided that passing a function value
taking multiple parameters would be allowed where a function value taking
a single tuple argument was expected.
Due to quirks in the old function type representation, the "splat" in the
other direction sometimes worked too. When we redid the function type
representation we added a simulation of the old quirk for -swift-version 4
mode.
However this simulation was itself problematic because it only worked when
the function value being passed was a non-overloaded declaration reference.
Slightly broaden the hack to the overloaded case, to prevent user
confusion when adding or removing overloads.