[sourcekitd] Report entities that are implicitly @objc as @objc in the index request responses for compatibility #22793
+138
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
akyrtzi
approved these changes
Feb 21, 2019
nathawes
force-pushed
the
add-implicit-at-objc-attributes-to-index-request-output
branch
from
8eed065 to
5702681
Compare
|
@swift-ci please smoke test |
nathawes
force-pushed
the
add-implicit-at-objc-attributes-to-index-request-output
branch
from
5702681 to
ec064e6
Compare
|
@swift-ci please test and merge |
|
@swift-ci test and merge |
|
@swift-ci test OS X |
|
Build failed |
…index request responses for compatibility Members of an @objcMembers context previous had implicit @objc attributes, but now don't (possibly because of the request evaluator changes?). This updates the output of sourcekitd's 'index' request to act as if they still had implicit @objc attributes on them for compatibility. Resolves rdar://problem/48140265
nathawes
force-pushed
the
add-implicit-at-objc-attributes-to-index-request-output
branch
from
ec064e6 to
7680cc6
Compare
|
@swift-ci test and merge |
|
@Swift-C test |
|
@swift-ci please smoke test Linux |
nathawes
deleted the
add-implicit-at-objc-attributes-to-index-request-output
branch
slavapestov
reviewed
Feb 26, 2019
|
The code change here updates sourcekitd to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. Members of an @objcMembers context previous had implicit @objc attributes but now don't (possibly because of the request evaluator changes?). This updates the output of sourcekitd's 'index' request to act as if they still had implicit @objc attributes on them for compatibility.
Resolves rdar://problem/48140265