Skip to content

[5.1] Replace mapIntoContext with DWARF Archetype name lookup. #22810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2019
Merged

[5.1] Replace mapIntoContext with DWARF Archetype name lookup. #22810

merged 3 commits into from
Feb 27, 2019

Conversation

adrian-prantl
Copy link
Contributor

@adrian-prantl adrian-prantl commented Feb 22, 2019 •
edited
Loading

This cherry-picks #22752 to the 5.1 branch.
rdar://problem/47798056

slavapestov and others added 3 commits February 22, 2019 09:13
@slavapestov @adrian-prantl
IRGen: DebugTypeInfo doesn't need a DeclContext or GenericEnvironment
3a3769e 
(cherry picked from commit c862253)
@adrian-prantl
Debug Info: Encode Archetype names in DWARF
c28c9cc 
Currently LLDB calls into ide::getDeclFromMangledSymbolName() to get
to this information and we would like to get rid of this call.

rdar://problem/47798056
(cherry picked from commit 54af8e4)
@adrian-prantl
Minor code cleanups (NFC)
ac78469 
(cherry picked from commit 3b7353a)
@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci test

@adrian-prantl adrian-prantl mentioned this pull request Feb 22, 2019
Merged
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ac78469

@slavapestov
Copy link
Contributor

LGTM. Sorry for blowing up your qualification branch with merge conflicts :)

@adrian-prantl
Copy link
Contributor Author

That was a SIL verification error; I don't think that could have been caused by this commit?

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ac78469

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ac78469

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci smoke test

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ac78469

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ac78469

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci smoke test

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci test platform linux

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ac78469

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ac78469

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci smoke test

1 similar comment
@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci smoke test

@adrian-prantl adrian-prantl changed the title IRGen: DebugTypeInfo doesn't need a DeclContext or GenericEnvironment Replace mapIntoContext with DWARF Archetype name lookup. Feb 26, 2019
@adrian-prantl adrian-prantl changed the title Replace mapIntoContext with DWARF Archetype name lookup. [5.1] Replace mapIntoContext with DWARF Archetype name lookup. Feb 26, 2019
@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#1321
@swift-ci test

@adrian-prantl adrian-prantl merged commit 4cc52aa into swiftlang:swift-5.1-branch Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-prantl @swift-ci @slavapestov