Fix a couple of check-swift-validation-optimize test failures #22834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
…ations are on @_optimize(none) does not prevent LLVM from optimizing the function, and the LLVM optimizer was able to inline blackHole() and elide the metadata access altogether.
We have to set the SILFunction's 'weakLinked' flag in the defining module too, so that it can be serialized. Otherwise when we deserialize it we are not weak linking calls to the function.
slavapestov
force-pushed
the
fix-optimized-test-failures
branch
from
5f59b64 to
b9bda84
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
|
swiftlang/swift-corelibs-foundation#1939 |
|
@swift-ci Please smoke test Linux |
slavapestov
added a commit
to slavapestov/swift
that referenced
this pull request
Mar 2, 2019
I meant to check this in a while ago; it was part of swiftlang#22834.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bot runs tests in this configuration. One failure was a test where the relevant runtime call was optimized away. The other problem was a regression from #22736. I added a reduced test case that doesn't depend on the optimizer.