[5.0] Disable long-running collection tests #22844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentey
changed the title
|
@swift-ci please test |
|
(Note: It's probably best to review this commit by commit -- the tests are gybbed and the last commit produces a lot of noise.) |
|
@swift-ci please nominate |
shahmishal
approved these changes
Feb 26, 2019
This was referenced Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is cherry-picked from #22320 and #22485)
Explanation: Unblocks CI builds by disabling time-consuming Collection validation tests in unoptimized builds. Currently these often take >50 minutes (especially on 32-bit simulator builds), triggering CI timeouts.
Scope: Limited to the test suite.
Radar: rdar://48321722
Risk: Minimal.
Testing: Local and CI testing on master; PR tests on swift-5.0-branch
Reviewer: @moiseev