IRGen: lazy initialize ForeignClassMetadata #22857

compnerd · 2019-02-24T06:38:28Z

This is needed for Windows which does not support cross-module data
references without indirection. By lazy initializing the data, we can
indirect through the IAT for the data pointer and fill in the parent
pointer.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd · 2019-02-24T06:38:37Z

CC: @slavapestov

slavapestov

This needs tests.

lib/IRGen/GenMeta.cpp

compnerd · 2019-02-28T00:31:34Z

CC: @mikeash

rjmccall

I think we could reasonably have the constructor for ForeignMetadataCacheEntry set the VWT if it's currently null. We should not try to initialize this in the completion function; I'm pretty sure the runtime assumes that the VWT will be set to something after allocation.

jckarter · 2019-03-01T22:33:51Z

My concern with that would be that not every foreign metadata is a CF class. It feels brittle to me to assume that, if no VWT is set, the one for foreign classes is always the best one to fill in.

compnerd · 2019-03-02T02:22:52Z

@rjmccall I did try to do that, but, it is currently marked as rdata, and Im trying to track down why that is. @jckarter - hmm, we could use the VWT entry itself for storage to figure out if we should overwrite it. I imagine that no OS that we care about ATM would use anything in the first page, so that gives us a good range to play with.

jckarter · 2019-03-02T02:32:51Z

Hm, maybe it's fine if we check that the type context descriptor describes a class, and set the VWT during foreign metadata setup if it is.

compnerd · 2019-03-03T18:31:55Z

@swift-ci please test

swift-ci · 2019-03-03T18:34:08Z

Build failed
Swift Test Linux Platform
Git Sha - a655b1cf59c8414b5c6d10ce1ac0add4e145a3f0

swift-ci · 2019-03-03T18:36:35Z

Build failed
Swift Test OS X Platform
Git Sha - a655b1cf59c8414b5c6d10ce1ac0add4e145a3f0

compnerd · 2019-03-04T16:14:06Z

@swift-ci please test

swift-ci · 2019-03-04T16:16:22Z

Build failed
Swift Test Linux Platform
Git Sha - 1a646ccf7e1cfae620334ebf181873ebb59d61fa

swift-ci · 2019-03-04T16:18:14Z

Build failed
Swift Test OS X Platform
Git Sha - 1a646ccf7e1cfae620334ebf181873ebb59d61fa

compnerd · 2019-03-04T17:15:28Z

@swift-ci please test

swift-ci · 2019-03-04T17:15:57Z

Build failed
Swift Test OS X Platform
Git Sha - 116755522cef735caa83d1416c8988501c08279d

swift-ci · 2019-03-04T17:17:27Z

Build failed
Swift Test Linux Platform
Git Sha - 116755522cef735caa83d1416c8988501c08279d

lib/IRGen/GenMeta.cpp

stdlib/public/runtime/Metadata.cpp

compnerd · 2019-03-06T20:03:45Z

@swift-ci please test

compnerd · 2019-03-06T20:29:56Z

@swift-ci please test

swift-ci · 2019-03-06T20:58:44Z

Build failed
Swift Test OS X Platform
Git Sha - aef7b94a681a94457ec72d24b808cd983a33990e

compnerd · 2019-03-06T23:35:28Z

@swift-ci please test

swift-ci · 2019-03-06T23:39:39Z

Build failed
Swift Test OS X Platform
Git Sha - aef7b94a681a94457ec72d24b808cd983a33990e

swift-ci · 2019-03-07T00:56:45Z

Build failed
Swift Test Linux Platform
Git Sha - 0c700ebdb1fdc9392fd5407fac4c73be7648ec76

compnerd · 2019-03-07T04:24:57Z

@swift-ci please test

swift-ci · 2019-03-07T06:18:28Z

Build failed
Swift Test OS X Platform
Git Sha - 0c700ebdb1fdc9392fd5407fac4c73be7648ec76

compnerd · 2019-03-07T16:51:39Z

@swift-ci please test macOS platform

ghost · 2019-03-07T17:11:00Z

https://bugs.swift.org/browse/SR-NNNN is a 404

compnerd · 2019-03-07T20:56:20Z

@rjmccall, @jckarter, @slavapestov - okay, so then this is good to merge? I will try to create a test case for the root protocol conformance, and then come back around to the SwiftRuntime work.

rjmccall

Just a bunch of comment requests, but otherwise this LGTM.

lib/IRGen/GenMeta.cpp

stdlib/public/runtime/Metadata.cpp

This is needed for Windows which does not support cross-module data references without indirection. By lazy initializing the data, we can indirect through the IAT for the data pointer and fill in the parent pointer.

compnerd · 2019-03-08T00:20:18Z

@swift-ci please test and merge

swift-ci · 2019-03-08T02:09:09Z

Build failed
Swift Test OS X Platform
Git Sha - 0c700ebdb1fdc9392fd5407fac4c73be7648ec76

compnerd · 2019-03-08T02:09:17Z

@swift-ci please test macOS platform

slavapestov reviewed Feb 26, 2019

View reviewed changes

lib/IRGen/GenMeta.cpp Outdated Show resolved Hide resolved

lib/IRGen/GenMeta.cpp Show resolved Hide resolved

lib/IRGen/GenMeta.cpp Outdated Show resolved Hide resolved

lib/IRGen/GenMeta.cpp Show resolved Hide resolved

lib/IRGen/GenMeta.cpp Outdated Show resolved Hide resolved

compnerd force-pushed the foreign-imports branch 2 times, most recently from 475dc39 to a655b1c Compare February 27, 2019 17:06

compnerd requested review from rjmccall and jckarter February 28, 2019 00:23

rjmccall reviewed Mar 1, 2019

View reviewed changes

compnerd force-pushed the foreign-imports branch from a655b1c to b2a8156 Compare March 2, 2019 02:19

compnerd force-pushed the foreign-imports branch 2 times, most recently from 40f4b68 to 1a646cc Compare March 3, 2019 18:31

compnerd force-pushed the foreign-imports branch from 1a646cc to 1167555 Compare March 4, 2019 16:13

compnerd force-pushed the foreign-imports branch from 1167555 to 6105bfd Compare March 4, 2019 17:12

rjmccall reviewed Mar 5, 2019

View reviewed changes

lib/IRGen/GenMeta.cpp Show resolved Hide resolved

compnerd force-pushed the foreign-imports branch 2 times, most recently from d536b71 to 8fff736 Compare March 5, 2019 16:52

rjmccall reviewed Mar 5, 2019

View reviewed changes

stdlib/public/runtime/Metadata.cpp Outdated Show resolved Hide resolved

compnerd force-pushed the foreign-imports branch from 8fff736 to 333d269 Compare March 6, 2019 03:56

compnerd force-pushed the foreign-imports branch from 333d269 to aef7b94 Compare March 6, 2019 20:29

compnerd force-pushed the foreign-imports branch from aef7b94 to 0c700eb Compare March 6, 2019 23:34

rjmccall requested changes Mar 7, 2019

View reviewed changes

lib/IRGen/GenMeta.cpp Show resolved Hide resolved

stdlib/public/runtime/Metadata.cpp Outdated Show resolved Hide resolved

IRGen: lazy initialize ForeignClassMetadata

3f829c2

This is needed for Windows which does not support cross-module data references without indirection. By lazy initializing the data, we can indirect through the IAT for the data pointer and fill in the parent pointer.

compnerd force-pushed the foreign-imports branch from 0c700eb to 3f829c2 Compare March 8, 2019 00:19

compnerd merged commit d4757d4 into swiftlang:master Mar 8, 2019

compnerd deleted the foreign-imports branch March 8, 2019 05:34

compnerd mentioned this pull request Feb 24, 2019

[SR-9652] foreign type metadata references VWT directly breaking Windows #52096

Closed

IRGen: lazy initialize ForeignClassMetadata #22857

IRGen: lazy initialize ForeignClassMetadata #22857

Uh oh!

Conversation

compnerd commented Feb 24, 2019

Uh oh!

compnerd commented Feb 24, 2019

Uh oh!

slavapestov left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compnerd commented Feb 28, 2019

Uh oh!

rjmccall left a comment

Choose a reason for hiding this comment

Uh oh!

jckarter commented Mar 1, 2019

Uh oh!

compnerd commented Mar 2, 2019

Uh oh!

jckarter commented Mar 2, 2019

Uh oh!

compnerd commented Mar 3, 2019

Uh oh!

swift-ci commented Mar 3, 2019

Uh oh!

swift-ci commented Mar 3, 2019

Uh oh!

compnerd commented Mar 4, 2019

Uh oh!

swift-ci commented Mar 4, 2019

Uh oh!

swift-ci commented Mar 4, 2019

Uh oh!

compnerd commented Mar 4, 2019

Uh oh!

swift-ci commented Mar 4, 2019

Uh oh!

swift-ci commented Mar 4, 2019

Uh oh!

Uh oh!

Uh oh!

compnerd commented Mar 6, 2019

Uh oh!

compnerd commented Mar 6, 2019

Uh oh!

swift-ci commented Mar 6, 2019

Uh oh!

compnerd commented Mar 6, 2019

Uh oh!

swift-ci commented Mar 6, 2019

Uh oh!

swift-ci commented Mar 7, 2019

Uh oh!

compnerd commented Mar 7, 2019

Uh oh!

swift-ci commented Mar 7, 2019

Uh oh!

compnerd commented Mar 7, 2019

Uh oh!

ghost commented Mar 7, 2019

Uh oh!

compnerd commented Mar 7, 2019

Uh oh!

rjmccall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

compnerd commented Mar 8, 2019

Uh oh!

swift-ci commented Mar 8, 2019

Uh oh!

compnerd commented Mar 8, 2019

Uh oh!