[ClangImporter] Refactor availability attribute importing logic. NFC. #22872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
beccadax
approved these changes
Feb 25, 2019
jrose-apple
reviewed
Feb 25, 2019
Refactor the PlatformAvailability logic for determining which Clang availability attributes are relevant when importing. The goal is to separate the logic for attribute relevance for a given platform from the logic to determine whether a deprecated attribute should be imported as unavailable in Swift. This also makes it possible for the "deprecated-as-unavailable" logic to refer to the underlying Clang declaration, which is functionality that will be used in a later commit. This commit has no intended functional change. Part of rdar://problem/48348822
devincoughlin
force-pushed
the
refactor-import-attrs
branch
from
90ca6d7 to
e80116d
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
devincoughlin
force-pushed
the
refactor-import-attrs
branch
from
e80116d to
b3ff2d8
Compare
|
Updated expected diagnostic text in SourceKit/DocSupport/doc_clang_module.swift.response |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
jrose-apple
approved these changes
Mar 4, 2019
beccadax
approved these changes
Mar 4, 2019
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
|
@swift-ci Please clean test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the PlatformAvailability logic for determining
which Clang availability attributes are relevant when importing. The goal
is to separate the logic for attribute relevance for a given platform from
the logic to determine whether a deprecated attribute should be imported as
unavailable in Swift.
This also makes it possible for the "deprecated-as-unavailable" logic to
refer to the underlying Clang declaration, which is functionality that will
be used in a later commit.
This commit has no intended functional change.
Part of rdar://problem/48348822