[sil-combine] When simplifying convert functions, base whether or not… #22887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an apply has nothrow on the actual function_ref. Previously, we based it off of whether or not the original apply had a nothrow bit. This is incorrect in the case where we added an error result to a function without an error result. In such a case, we need to /not/ put on the nothrow bit. This commit generalizes this idea slightly by assuming that if we are asked to perform this transformation we should just match what the underlying function_ref (i.e. setting nothrow if the underlying function type has an error result and not setting nothrow if the underlying function type does not have an error result). rdar://47828439 (cherry picked from commit 4d90cdd)
|
@swit-ci smoke test |
|
@swift-ci test |
|
Build failed |
|
I'm cherry-picking this into #22819 and fixing the existentials_objc failure there. |
|
I think Slava is going to include this patch in his changes. I'll keep this open until he finishes. |
|
Slava merged in #22819... closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… an apply has nothrow on the actual function_ref.
Previously, we based it off of whether or not the original apply had a nothrow
bit. This is incorrect in the case where we added an error result to a function
without an error result. In such a case, we need to /not/ put on the nothrow
bit. This commit generalizes this idea slightly by assuming that if we are asked
to perform this transformation we should just match what the underlying
function_ref (i.e. setting nothrow if the underlying function type has an error
result and not setting nothrow if the underlying function type does not have an
error result).
rdar://47828439
(cherry picked from commit 4d90cdd)