[5.0][Sema] Add defensive guard for implicit use of self in closure check #22912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add assetion along with defensive guard to avoid crashing in release build. Hopefully, sourcekitd Stress Tester find a reproducer for the crash. rdar://problem/47895109 (cherry picked from commit ce30a72)
|
@swift-ci Please test |
|
@swift-ci Please nominate |
akyrtzi
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-pick of #22908 for swift-5.0-brach)
isImplicitSelfUse(). This change adds defensive check for nullTypeto avoid crashing in release build. This function is for diagnosing implicitselfusage in closure. If the expression doesn't haveTypehere, it should have been diagnosed somewhere else. So in that case, we can skip the check.selfusages in closure.rdar://problem/47895109