Skip to content

[5.1][Sema] Add defensive guard for implicit use of self in closure check #22913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Feb 26, 2019

(Cherry-pick of #22908 for swift-5.1-branch)

Add assetion along with defensive guard to avoid crashing in release
build. Hopefully, sourcekitd Stress Tester find a reproducer for the
crash.

rdar://problem/47895109

Add assetion along with defensive guard to avoid crashing in release
build. Hopefully, sourcekitd Stress Tester find a reproducer for the
crash.

rdar://problem/47895109
(cherry picked from commit ce30a72)
@rintaro
Copy link
Member Author

rintaro commented Feb 26, 2019

@swift-ci Please test

@rintaro rintaro changed the title [Sema] Add defensive guard for implicit use of self in closure check [5.1][Sema] Add defensive guard for implicit use of self in closure check Feb 26, 2019
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 413d7eb

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 413d7eb

@rintaro
Copy link
Member Author

rintaro commented Feb 27, 2019

@swift-ci Please test

@rintaro rintaro merged commit 7710d63 into swiftlang:swift-5.1-branch Feb 28, 2019
@rintaro rintaro deleted the 5.1-sema-implicitselfinclosure-rdar47895109 branch February 28, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants