Skip to content

[5.0] Generalize alloc_box test for different platforms #22922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

[5.0] Generalize alloc_box test for different platforms #22922

merged 1 commit into from
Feb 27, 2019
+2 −2

Conversation

levivic
Copy link
Contributor

@levivic levivic commented Feb 26, 2019

This is backport for #22754

@levivic levivic requested a review from a team as a code owner February 26, 2019 14:57
@compnerd compnerd changed the title Generalize alloc_box test for different platforms [5.0] Generalize alloc_box test for different platforms Feb 26, 2019
@bob-wilson
Copy link
Contributor

@swift-ci please test

bob-wilson
bob-wilson approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me. Since it only touches a test file, I don't think we need CCC review.

@bob-wilson bob-wilson merged commit feacc3f into swiftlang:swift-5.0-branch Feb 27, 2019
@levivic
Copy link
Contributor Author

levivic commented Feb 27, 2019

Thanks.

@levivic levivic deleted the swift-5.0-s390x-test-allocbox-1 branch February 27, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bob-wilson bob-wilson bob-wilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@levivic @bob-wilson