DominatedAccessRemoval and AccessEnforcementOpts bug fixes #22929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
|
@atrick this is failing because your patch that prevents merging read and modify does not seem to be merged into 5.1 branch, can you please cherry-pick it? |
added 2 commits
February 28, 2019 14:04
AccessEnforcementOpts: Fix a bug that caused a compiler assert when dealing with nested scopes
DominatedAccessRemoval: fix a bug wherein we incorrectly removes nested conflicting accesses
shajrawi
force-pushed
the
cherry_to_51_excl
branch
from
d56e154 to
c505dc5
Compare
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/48318054 and rdar://problem/48323041
Cherry-pick of #22838 and #22833