Skip to content

[Stdlib] Make SwiftObjectNSObject actually pass on older OSes where the real test is disabled. #22950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Feb 27, 2019

It helps to print the fake messages where FileCheck will actually be looking for them.

rdar://problem/48421324

…he real test is disabled.

It helps to print the fake messages where FileCheck will actually be looking for them.

rdar://problem/48421324
@mikeash
Copy link
Contributor Author

mikeash commented Feb 27, 2019

@swift-ci please smoke test and merge

@Catfish-Man
Copy link
Contributor

That linux failure looks unrelated. I can force merge if OSX looks good.

@mikeash
Copy link
Contributor Author

mikeash commented Feb 27, 2019

Sounds good. I don't know what's up with that Linux failure but I can't see how it could possibly be due to this change.

@Catfish-Man Catfish-Man merged commit 22e657a into swiftlang:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants