Skip to content

Implement SeparateErrors on Windows #22961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Conversation

gmittert
Copy link
Contributor

To display stack traces from child processes, the driver combines stdout
and stderror together on Unix. This makes the Basic implementation also
do that.

@gmittert
Copy link
Contributor Author

@jrose-apple

Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should have a mode that forces the compiler to use the Basic implementation even on POSIXy platforms, but for now we'll have to rely on your checking. Thank you!

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test

@jrose-apple jrose-apple self-assigned this Feb 27, 2019
To display stack traces from child processes, the driver combines stdout
and stderror together on Unix. This makes the Basic implementation also
do that.
@gmittert
Copy link
Contributor Author

Fixed an issue with it, can you re trigger the smoke test?

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test macOS

@compnerd compnerd merged commit 0cf6f5f into swiftlang:master Feb 28, 2019
@gmittert gmittert deleted the PassByStack branch February 28, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants