Print nil unwrap location in no-assert builds of stdlib #22964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
lorentey
approved these changes
Feb 27, 2019
| reason: "this trap is not guaranteed to happen in -Ounchecked")) | ||
| .crashOutputMatches(_isDebugAssertConfiguration() | ||
| ? "test/stdlib/OptionalTraps.swift, line 45" | ||
| : "") |
moiseev
force-pushed
the
nil-unwrap-location
branch
from
a03b8bd to
d9f221a
Compare
We've been collecting the location info for some time now, but apparently never printed it in no-assert builds of the stdlib, which means this functionality was never available to the users. With this change, the location will be printed depending on the debug/release build configuration of the program, not stdlib. Somewhat addresses: <rdar://problem/42980523>
moiseev
force-pushed
the
nil-unwrap-location
branch
from
d9f221a to
2ce0630
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
#23011 should address the Windows regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been collecting the location info for some time now, but
apparently never printed it in no-assert builds of the stdlib, which
means this functionality was never available to the users.
With this change, the location will be printed depending on the
debug/release build configuration of the program, not stdlib.
Somewhat addresses: rdar://problem/42980523