Skip to content

[CodeCompletion] Add a regression test for SR-2560 #22966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

AnthonyLatsis
Copy link
Collaborator

сс @rintaro

SR-2560 seems to have been unknowingly fixed.

@AnthonyLatsis AnthonyLatsis changed the title Add a regression test for SR-2560 [CodeCompletion] Add a regression test for SR-2560 Feb 28, 2019
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rintaro
Copy link
Member

rintaro commented Feb 28, 2019

@swift-ci Please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

Although the way it prints doesn't perfectly match the requirement's generic signature style. Do you think we should always make sure to perfectly match the style of the base declaration?

@rintaro
Copy link
Member

rintaro commented Feb 28, 2019

I don't think they should perfectly match.
But ideally, I think, we should keep constraints position (generic params or where clause).
So in this case,

    foo<S: Sequence>(x: S) where S.Element == Int {
        <#code#>
    }

is preferable because the original : Sequence constraint is in the generic param clause.

@AnthonyLatsis
Copy link
Collaborator Author

Yes, agreed.

I am going to work on SR-9560 soon; taking advantage of the moment, could you hint me where to look at for how ↵(enter) actions on placeholders are implemented?

@rintaro
Copy link
Member

rintaro commented Feb 28, 2019

@AnthonyLatsis Commented in SR-9560 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants