FloatLiteralExpr now is lowered directly into SIL. #23010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
reviewed
Mar 1, 2019
|
Thank you so much for doing this! |
For context, String, Nil, Bool, and Int already behave this way. Note: Swift can compile against 80 or 64 bit floats as the builtin literal type. Thus, it was necessary to capture this bit somehow in the FloatLiteralExpr. This was done as another Type field capturing this info.
slavapestov
approved these changes
Mar 1, 2019
| _blackHole(UInt8(-1E309)) // expected-error {{negative literal '-1E309' cannot be converted to 'UInt8'}} | ||
| _blackHole(Int64(1E309)) // expected-error {{invalid conversion: '1E309' overflows 'Int64'}} | ||
| _blackHole(UInt64(-1E309)) // expected-error {{negative literal '-1E309' cannot be converted to 'UInt64'}} | ||
| _blackHole(Int8(1E308)) // expected-error {{invalid conversion: '1E308' overflows 'Int8'}} |
There was a problem hiding this comment.
Great to see these fixed too!
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
|
@pschuh I just noticed this. It is nice that false negatives in floating point overflow/underflow detection are fixed by this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, String, Nil, Bool, and Int already behave this way.
Note: Swift can compile against 80 or 64 bit floats as the builtin
literal type. Thus, it was necessary to capture this bit somehow in the
FloatLiteralExpr. This was done as another Type field capturing this
info.