Have Windows Call Signaled Callback on Crashes #23018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrose-apple
approved these changes
Mar 1, 2019
| // Wait() returning a return code of -2 indicates the process received | ||
| // a signal during execution. | ||
| if (ReturnCode == -2) { | ||
| #endif |
There was a problem hiding this comment.
Nitpick: I dislike #ifs that don't surround a whole unit of AST. Mind factoring this out into a boolean?
The signaled callback is treated more as a general crash handler clean up wise. While it doesn't 100% line up, have Windows call the signaled callback on exit codes considered to be errors.
gmittert
force-pushed
the
ThatsAGoodSignal
branch
from
25bbd20 to
5d095bc
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signaled callback is treated more as a general crash handler clean
up wise. While it doesn't 100% line up, have Windows call the signaled
callback on exit codes considered to be errors.
See #22985 (comment)