[cast-opt] Fix obvious bug. #23070
Merged
[cast-opt] Fix obvious bug. #23070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via inspection. The code is supposed to check if either the source or the target is NSError and in such a case bail.
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
eeckstein
approved these changes
Mar 5, 2019
|
Hmmm... let me see what I can come up with. I thought it was going to be hard to do, but I might be able to get something now that I think about it. |
|
Just cleaning up my branches |
|
@gottesmm Should this still be open? |
|
I am going to retest/merge this. I couldn't come up with a test case at the time that actually caused this (it may not be possible since I think other conditions in other places would stop us from hitting the problem). My memory is that the code actively clashed with the comments/patterns. |
|
@swift-ci smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via inspection. The code is supposed to check if either the source or the
target is NSError and in such a case bail.