Serialization: Also serialize the filename for internal storage decls with private accessors #23074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with private accessors If a value decl is internal hasTestableOrPrivateImport will succeed (or fail) without looking at the filename. However this breaks when we query an internal storage decl with private formal access for a private setter: the query would fail because no filename was serialized for the decl (we only serialize filenames for private decls). So in the special case of a internal storage with private accessor also serialize the filename. rdar://48516545
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Static analysis run from Xcode? |
jrose-apple
reviewed
Mar 5, 2019
lib/Serialization/Serialization.cpp
Outdated
| !value->getDeclContext()->isLocalContext() && | ||
| (access <= swift::AccessLevel::FilePrivate || | ||
| (storage && | ||
| storage->getFormalAccess() == swift::AccessLevel::Internal && |
There was a problem hiding this comment.
Couldn't it be public with a private setter?
There was a problem hiding this comment.
yes. thanks!
I had mistakingly tested
public struct Foo {
private(set) var publicVarWithPrivateSetter : Int = 0
instead of
struct Foo {
public private(set) var publicVarWithPrivateSetter : Int = 0
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a value decl is internal hasTestableOrPrivateImport will succeed (or
fail) without looking at the filename. However this breaks when we query
an internal storage decl with private formal access for a private
setter: the query would fail because no filename was serialized for the
decl (we only serialize filenames for private decls). So in the special
case of a internal storage with private accessor also serialize the
filename.
rdar://48516545