[cast-opt] Eliminate always true if statement. #23086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
|
Sorry. I meant to write that there has been a long time assert that Src is an address and BridgedObject has always been an object. I am going to fix the commit msg and retest. |
I think that this is a result of previous refactorings. This code has a long time assert in it that Src (since 2016) is an address and for a long time the bridged type has always been an object (since 2015). So, thus we know that the following is always true. SILBridgedTy != Src->getType() I also removed a level of indentation. NFC. The 2015 commit hash is: 2dd38ee (the original commit). The 2016 commit hash is: 506ab98
gottesmm
force-pushed
the
pr-706deb33fc2fb07b5b920a486f7696ceb08a8fc3
branch
from
1117aa0 to
2764559
Compare
|
@swift-ci smoke test and merge |
3 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this is a result of previous refactorings. This code has a long
time assert in it that Src (since 2016) is an object and for a long time the bridged type has
always been an object (since 2015). So, thus we know that the following is always true.
SILBridgedTy != Src->getType()
I also removed a level of indentation. NFC.
The 2015 commit hash is: 2dd38ee (the original commit).
The 2016 commit hash is: 506ab98