Skip to content

[cast-opt] Extract out the retrieval of the ObjC -> Swift bridging fu… #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2019
Merged

[cast-opt] Extract out the retrieval of the ObjC -> Swift bridging fu… #23090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions lib/SILOptimizer/Utils/CastOptimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,27 @@

using namespace swift;

static SILFunction *
getObjCToSwiftBridgingFunction(SILOptFunctionBuilder &funcBuilder,
SILDynamicCastInst dynamicCast) {
// inline constructor.
auto *bridgeFuncDecl = [&]() -> FuncDecl * {
auto &astContext = dynamicCast.getModule().getASTContext();
if (dynamicCast.isConditional()) {
return astContext.getConditionallyBridgeFromObjectiveCBridgeable();
}
return astContext.getForceBridgeFromObjectiveCBridgeable();
}();

assert(bridgeFuncDecl && "Bridging function doesn't exist?!");

SILDeclRef funcDeclRef(bridgeFuncDecl, SILDeclRef::Kind::Func);

// Lookup a function from the stdlib.
return funcBuilder.getOrCreateFunction(dynamicCast.getLocation(), funcDeclRef,
ForDefinition_t::NotForDefinition);
}

/// Create a call of _forceBridgeFromObjectiveC_bridgeable or
/// _conditionallyBridgeFromObjectiveC_bridgeable which converts an ObjC
/// instance into a corresponding Swift type, conforming to
Expand All @@ -67,20 +88,9 @@ CastOptimizer::optimizeBridgedObjCToSwiftCast(SILDynamicCastInst dynamicCast) {
// The conformance to _BridgedToObjectiveC is statically known.
// Retrieve the bridging operation to be used if a static conformance
// to _BridgedToObjectiveC can be proven.
FuncDecl *BridgeFuncDecl =
isConditional
? M.getASTContext().getConditionallyBridgeFromObjectiveCBridgeable()
: M.getASTContext().getForceBridgeFromObjectiveCBridgeable();

assert(BridgeFuncDecl && "_forceBridgeFromObjectiveC should exist");

SILDeclRef FuncDeclRef(BridgeFuncDecl, SILDeclRef::Kind::Func);

// Lookup a function from the stdlib.
SILFunction *BridgedFunc = FunctionBuilder.getOrCreateFunction(
Loc, FuncDeclRef, ForDefinition_t::NotForDefinition);

if (!BridgedFunc)
SILFunction *bridgingFunc =
getObjCToSwiftBridgingFunction(FunctionBuilder, dynamicCast);
if (!bridgingFunc)
return nullptr;

CanType CanBridgedTy = BridgedTargetTy->getCanonicalType();
Expand Down Expand Up @@ -170,9 +180,9 @@ CastOptimizer::optimizeBridgedObjCToSwiftCast(SILDynamicCastInst dynamicCast) {
M.getASTContext().getProtocol(KnownProtocolKind::ObjectiveCBridgeable);
auto Conf = *M.getSwiftModule()->lookupConformance(Target, BridgedProto);

auto ParamTypes = BridgedFunc->getLoweredFunctionType()->getParameters();
auto ParamTypes = bridgingFunc->getLoweredFunctionType()->getParameters();

auto *FuncRef = Builder.createFunctionRef(Loc, BridgedFunc);
auto *FuncRef = Builder.createFunctionRef(Loc, bridgingFunc);

auto MetaTy = MetatypeType::get(Target, MetatypeRepresentation::Thick);
auto SILMetaTy = F->getTypeLowering(MetaTy).getLoweredType();
Expand Down