Increase the stack size limit for running llvm codegen threads to 8MB #23102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this compilation may fail in llvm because we run out of stack space. The limit for the main thread is 8MB on mac osx but 512KB for other threads. rdar://47787344
|
@swift-ci Please test |
|
Build failed |
|
Did we run out of disk space ... |
|
@swift-ci Please smoke test OS X platform |
jrose-apple
reviewed
Mar 11, 2019
| pthread_attr_destroy(&stackSizeAttribute); | ||
| #else | ||
| for (auto &thread : threads) { | ||
| thread.thread = new std::thread(runThread, &thread); |
There was a problem hiding this comment.
Why does it need to be heap-allocated?
There was a problem hiding this comment.
It does not.
#23214
|
The default stack size for pthread_create on linux is not as low as on Mac OS: 2MB not 512Kb. We could also increase this to 8MB. |
|
Is this shipped with latest xcode 10.2 ? |
|
My problem was Cache library i used : hyperoslo/Cache#238 |
|
This would not have made it into Xcode 10.2, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this compilation may fail in llvm because we run out of stack space. The
limit for the main thread is 8MB on mac osx but 512KB for other threads.
rdar://47787344