[Constraint solver] Move all partitioning into partitionDisjunction #23114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oning This narrow favoring rule makes more sense as part of disjunction partitioning, because it is not dependent on the use site at all and should only kick in when other options fail.
…partitioning Continuing along my path to move application-independent partitioning rules into the common disjunction partitioning code.
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macOS |
1 similar comment
|
@swift-ci please smoke test macOS |
DougGregor
force-pushed
the
constraint-solver-partition-cleanup
branch
from
6e1f3ab to
fd50d94
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize the various attempts to partition an overload set into
ConstraintSystem::partitionDisjunction(), so we have a single place where this logic can be reasoned about and updated.