Fix the Rest of the Windows Driver Tests

[gmittert]

This (along with #23040) makes driver tests now pass on Windows:

S:\bd\swift> C:\Python27\python.exe S:/b/llvm/bin/llvm-lit.py S:\bd\swift\test-windows-x86_64\ -sv --filter "Driver" -sv                                                                                                                                                                                                                              
...
-- Testing: 153 of 4520 tests, 12 threads --                                                                                                                                                                                                                                                                                                          
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..                                                                                                                                                                                                                                                                                            
Testing Time: 211.16s                                                                                                                                                                                                                                                                                                                                 
  Expected Passes    : 116                                                                                                                                                                                                                                                                                                                            
  Expected Failures  : 5                                                                                                                                                                                                                                                                                                                              
  Unsupported Tests  : 32                                                                                                                                                                                                                                                                                                                             
                                                                                                                                                                                                                                                                                                                                                      
3 warning(s) in tests. 

[compnerd]

@swift-ci please test

[compnerd]

This looks great to me, the only thing that stands out is the use of -fansi-escape-codes which @jrose-apple might have issues with (since the driver may be run in a case where we don't want that - !isatty(stdout).

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 2e29aed6a4531cb36a1638f45a12f526ae24fec9

[gmittert]

Fixed the pylint import order issue.

[gmittert]

This looks great to me, the only thing that stands out is the use of -fansi-escape-codes which @jrose-apple might have issues with (since the driver may be run in a case where we don't want that - !isatty(stdout).

Passing -fansi-escape-codes doesn't do anything on non Windows platforms, on Unix, clang calls Process::UseANSIEscapeCodes which does nothing:

// llvm/lib/Support/Unix/Process.inc:402
void Process::UseANSIEscapeCodes(bool /*enable*/) {
  // No effect.
}

On Windows, it toggles using ANSI instead of SetConsoleMode. The actual choice to emit them is a different option.

[compnerd]

Oh, yeah, we shouldn't use SetConsoleMode at all, especially now that the console has been rewritten to basically be ANSI escape code driven.

[compnerd]

@swift-ci please test and merge

[gmittert]

Fair to say that 13:17:58 TIMEOUT: test_dwarf (lang/swift/generic_extensions_typealias/TestGenericExtensionsTypealias.py) is unrelated?

[compnerd]

@swift-ci please test macOS platform

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 2e29aed6a4531cb36a1638f45a12f526ae24fec9

[jrose-apple]

This should be conditionalized on DiagnosticOptions::UseColor, no? Or will it just not use the escape codes if they never come up?

[gmittert]

Exactly, if color is emitted, it'll use ansi escapes instead of SetConsoleMode, but it doesn't actually trigger the use of color.