Skip to content

[Constraint solver] Remove a dubious hack introduced with SR-2505 #23125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

No description provided.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility debug

@DougGregor
Copy link
Member Author

@swift-ci please test source compatibility release

This test is technically scaling linearly in the metrics being
checked, but it was still taking 5+ minutes to type check. Reduce the
upper bound so it finishes in a reasonable amount of time.
@DougGregor DougGregor force-pushed the constraint-solver-remove-sr-2505-hack branch from 20f2530 to 2975237 Compare March 6, 2019 20:01
@DougGregor
Copy link
Member Author

Source compatibility tests ran cleanly; rebased to narrow this down to only the new commits and documented the change in a ChangeLog entry.

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor
Copy link
Member Author

@swift-ci please smoke test

1 similar comment
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor merged commit 719547f into swiftlang:master Mar 7, 2019
@DougGregor DougGregor deleted the constraint-solver-remove-sr-2505-hack branch March 7, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant