[silgenpattern] NFC cleanups in preparation for fixing fallthrough issue #23132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test and merge |
…its own function. This makes it easier to read/reason about SILGenPattern::emitSwitchStmt().
gottesmm
commented
Mar 6, 2019
gottesmm
force-pushed
the
pr-3ed566dc0f1adb6be65627cc8b34ba8e5e3ebe39
branch
from
92c3a34 to
1781318
Compare
…if condition and using an early exit.
gottesmm
force-pushed
the
pr-3ed566dc0f1adb6be65627cc8b34ba8e5e3ebe39
branch
from
1781318 to
4fefea5
Compare
|
@swift-ci smoke test and merge |
4 similar comments
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test and merge |
shahzadlone
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just consists of 3 NFC commits that fix up the code a bit. I am doing this so that #23056 is easier to review by upstreaming these first.