Skip to content

[preset] Add sourcekit-lsp to swiftpm PR presets #23136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

benlangmuir
Copy link
Contributor

In anticipation of moving sourcekit-lsp to build with swiftpm master
without using a Package.resolved pin, add sourcekit-lsp to the PR tests
for swiftpm.

In anticipation of moving sourcekit-lsp to build with swiftpm master
without using a Package.resolved pin, add sourcekit-lsp to the PR tests
for swiftpm.
@benlangmuir
Copy link
Contributor Author

preset=buildbot_swiftpm_macos_platform,tools=RA,stdlib=RA
@swift-ci Please test with preset macOS

@benlangmuir
Copy link
Contributor Author

preset=buildbot_swiftpm_linux_platform,tools=RA,stdlib=RA
@swift-ci Please test with preset Linux

@benlangmuir
Copy link
Contributor Author

preset=buildbot_swiftpm_linux_platform,tools=RA,stdlib=RA
@swift-ci Please test with preset Linux

@benlangmuir
Copy link
Contributor Author

preset=buildbot_swiftpm_macos_platform,tools=RA,stdlib=RA
@swift-ci Please test with preset macOS

@benlangmuir
Copy link
Contributor Author

@swift-ci please smoke test

@benlangmuir
Copy link
Contributor Author

@aciidb0mb3r as we discussed, this adds sourcekit-lsp to the swiftpm PR tests. The build is ~3 minutes, which is slower than I expected, but explainable by hardware and load differences with my machine. I need to fix a couple of slow tests (swiftlang/sourcekit-lsp#90), but after that the tests should be < 10 seconds.

@aciidgh
Copy link
Contributor

aciidgh commented Mar 7, 2019

Sounds good but please make sure to not run any perf tests on the PR bots.

@benlangmuir benlangmuir merged commit f07a84a into swiftlang:master Mar 7, 2019
@benlangmuir benlangmuir deleted the prize-lsp branch March 7, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants