Skip to content

More TypeRef uniquing #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2016
Merged

More TypeRef uniquing #2315

merged 3 commits into from
Apr 26, 2016

Conversation

bitjammer
Copy link
Contributor

Address a few post-commit review comments:

  • Include some more uniquing info for Metatypes.
  • Don't bother with parent pointers in nominal-ish types.
  • Move uniquing logic / macro into the static create functions for typerefs so they can continue to be created and uniqued that way as well as with the TypeRefBuilder methods.

@bitjammer
Copy link
Contributor Author

@swift-ci Please smoke test

@bitjammer
Copy link
Contributor Author

The OS X PR bot is building too much again, so I'm going to build the tests locally in parallel.

@bitjammer
Don't include Parent pointer in Nominal/BoundGeneric TypeRef uniquing
8e0412f 
This information is already in the mangled type name.
@bitjammer
Move cache check into TypeRefs' static create methods
243bc75 
along with the boilerplate macro. This allows one to create TypeRefs
with either the builder or via the static methods, so long as a builder
argument is supplied so uniquing caches can be checked.

rdar://problem/25924875
@bitjammer bitjammer merged commit cbac702 into swiftlang:master Apr 26, 2016
@bitjammer bitjammer deleted the typeref-uniquing branch April 26, 2016 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bitjammer