Include PR16372 in swift-4.2-branch to support Clang 7.0+ (Ubuntu 18.10) #23154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need confirmation from @tkremenek & @rjmccall here |
|
@swift-ci test 4.2 |
1 similar comment
|
@swift-ci test 4.2 |
|
@swift-ci please test |
|
Build failed |
|
@shahmishal is this failure also the same 'Xcode too new' problem we had before with the 'Swift Test OS X Platform'? It did pass the 4.2 OSX platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If swift-4.2-branch can still be changed for the 4.2.x linux-only releases, #16372 could be included to be able to compile on systems with clang 7.0 or greater (i.e. Ubuntu 18.10+, so not one of the LTS usually supported).
Since that PR alone doesn't apply cleanly, this new PR contains the result of applying #16212, #16221 and #16372, with some minor formatting updates to align
TypeRef.hto what we have right now onmasterand the swift-5 branches.