Skip to content

SwiftRemoteMirror: repair the windows build #23178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Mar 8, 2019

This symbol is meant to be exposed to users of the SwiftRemoteMirror
library which requires that it is explicitly marked with the appropriate
DLL storage on Windows. This should repair the Windows build.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Mar 8, 2019

@swift-ci please smoke test and merge

@compnerd
Copy link
Member Author

compnerd commented Mar 8, 2019

CC: @mikeash

Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you figure out the include failure.

This symbol is meant to be exposed to users of the SwiftRemoteMirror
library which requires that it is explicitly marked with the appropriate
DLL storage on Windows.  This should repair the Windows build.
@compnerd compnerd force-pushed the the-mirror-is-broken branch from 36e934e to fbd456b Compare March 8, 2019 15:59
@compnerd
Copy link
Member Author

compnerd commented Mar 8, 2019

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit a2cd52c into swiftlang:master Mar 8, 2019
@compnerd compnerd deleted the the-mirror-is-broken branch March 8, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants