Skip to content

Re-reapply #23107 (Interpreter/bridged_cast_folding.swift) #23185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2019
Merged

Re-reapply #23107 (Interpreter/bridged_cast_folding.swift) #23185

merged 3 commits into from
Apr 18, 2019

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Mar 8, 2019

Fix and reinstate bridge cast folding test so that is gets resilient against changes in Foundation's class cluster behavior across platforms and OS versions.

#23107

Note: One test case requires that #23174 lands before this one.

@lorentey lorentey requested a review from gottesmm March 8, 2019 19:32
@lorentey lorentey mentioned this pull request Mar 15, 2019
Merged
@lorentey
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a75cb54c268763f42cbfe9cf85da05fba2317b27

@lorentey
Copy link
Member Author 

/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/test/Interpreter/bridged_casts_folding.swift:311:16: error: CHECK-OPT: expected string not found in input
18:34:49  // CHECK-OPT: stderr>>> OK: saw expected "crashed: sigill"
18:34:49                ^
18:34:49 <stdin>:32:1: note: scanning from here
18:34:49 stderr>>> Could not cast value of type 'NSTaggedPointerString' (0x7fff8e4216b0) to 'NSNumber' (0x7fff8e8d2ac0).
18:34:49 ^
18:34:49 <stdin>:33:1: note: possible intended match here
18:34:49 stderr>>> OK: saw expected "crashed: sigabrt"

🤦🏻‍♂️💆🏻‍♂️

@lorentey lorentey force-pushed the in-memory-of-tubby-the-spaniel branch from a75cb54 to ae1bc76 Compare March 28, 2019 21:32
@lorentey
Copy link
Member Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ae1bc76

@lorentey
Copy link
Member Author

@swift-ci test macOS platform

@lorentey
Copy link
Member Author

@swift-ci test and merge

@swift-ci swift-ci merged commit fa43e3b into swiftlang:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottesmm gottesmm Awaiting requested review from gottesmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @swift-ci