Skip to content

build: try to fix swift-reflection-test harder #23196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Mar 9, 2019

Ensure that the symbol is marked for DLL import rather than just as a local.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Ensure that the symbol is marked for DLL import rather than just as a local.
@compnerd
Copy link
Member Author

compnerd commented Mar 9, 2019

@swift-ci please smoke test and merge

Copy link
Contributor

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, the build system needs to manage this better...

@gwynne
Copy link
Contributor

gwynne commented Mar 9, 2019

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 52ddabe into master Mar 9, 2019
@compnerd compnerd deleted the self-reflection-is-difficult branch March 9, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants