[5.1][SE-0240] Ordered Collection Diffing #23197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1af14db)
… tests (cherry picked from commit 7c13fe3)
(cherry picked from commit c0c068d)
(cherry picked from commit df3a058)
…tance (cherry picked from commit b467e24)
(cherry picked from commit b7f36c3)
…edChanges:) (cherry picked from commit 4552291)
…k, causing some strange crashes (cherry picked from commit 9b45fc4)
- Add an underscore to private/internal symbols - Make access levels explicit, even when they’re implied from context - Conform to max line length of 80 characters - Conformances declared on separate extensions that implement them - Arrange member declarations so that stored properties appear first - Expand single-letter function and type parameter names where there is an obvious name that’s more descriptive - RangeReplaceableCollection.fastApplicationEnumeration → CollectionDifference._fastEnumeratedApply (cherry picked from commit 57f4afb)
(cherry picked from commit fd32a3d)
(cherry picked from commit f414c16)
|
@swift-ci please test |
|
Build failed |
|
https://ci.swift.org/job/swift-PR-Linux/11642/: This again! But how? |
|
@swift-ci please test linux platform |
numist
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #21845, implementing SE-0240, Ordered Collection Diffing.