Remove custom handling in add_swift_host_library #23204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the appropriate CMake mechanism for controlling flags for building the code.
|
@swift-ci please smoke test |
gwynne
reviewed
Mar 10, 2019
Use the appropriate CMake mechanism for building the libraries.
This is not currently being used. Unfortunately, setting linker options is difficult until CMake 3.13 which introduced target_link_options. Prior to that, you needed to do: set_property(TARGET <TARGET> APPEND_STRING LINK_FLAGS <NEW FLAGS>) If needed, we could write a helper to provide the target_link_options interface on earlier CMake versions.
Use the appropriate CMake mechanisms for building the libraries.
compnerd
force-pushed
the
silence-in-the-library
branch
from
bc3160f to
533a26a
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
@Rostepher, @gottesmm - is this okay? |
|
@Rostepher @gottesmm - ping x 2? |
|
@Rostepher @gottesmm - ping x 3 |
|
I checked all instances of uses of this and it merges cleanly. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.