[silgen] Fix a bug where when reabstracting T:P -> P we wrapped a +0 … #23216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value in an init_existential_ref. Found via the ownership verifier running on IRGen/outlined_copy_addr.swift. We treat initialization of an existential as a +1 operation, so there is the possibility that we would have double destroyed a value. In fixing this I followed what manageOpaqueValue did on the first code path, since it is handling this case correctly (and using the SGFContext to do so to boot!). To ensure this is tested, I enabled ownership verification on the test and since it seems to be exposing a SILGen code path that we aren't testing currently, converted it into a SILGen test.
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…value in an init_existential_ref.
Found via the ownership verifier running on IRGen/outlined_copy_addr.swift.
We treat initialization of an existential as a +1 operation, so there is the
possibility that we would have double destroyed a value. In fixing this I
followed what manageOpaqueValue did on the first code path, since it is handling
this case correctly (and using the SGFContext to do so to boot!).
To ensure this is tested, I enabled ownership verification on the test and since
it seems to be exposing a SILGen code path that we aren't testing currently,
converted it into a SILGen test.