[lit] Change all %target-swift-frontend invocations to verify ownership. #23260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are already doing this for most of the target-swift-frontend ones. In a subsequent commit, I am going to remove the redundant ones. NOTE: On Darwin, I have not enabled it on the %target-swift-frontend mock SDK commands. I ran into an issue with one of the PrintAsObjC tests that I am still tracking down. I would rather just get this turned on to prevent further regressions. I also updated a few tests that needed some small tweaks to pass this. Specifically: 1. Some parser tests needed some extra ossa insts to pass the verifier. This doesn't effect what they actually test. 2. IRGen tests that should never have processed ossa directly. Today, we are working towards a world where IRGen never processes [ossa] directly. Instead we lower first. If/when that changes, we should add back in specific [ossa] tests. 3. A singular SILOptimizer definite init test case where the ownership verifier fails due to a case which DI already flags as illegal (we just crash earlier). I am going to look into fixing that by putting in errors in the typechecker or in SILGen (not sure yet). I changed it to use target-swiftc_driver which does not have ownership verification enabled.
|
@swift-ci smoke test and merge |
|
@swift-ci smoke test OSX platform |
|
@swift-ci smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are already doing this for most of the target-swift-frontend ones. In a
subsequent commit, I am going to remove the redundant ones.
NOTE: On Darwin, I have not enabled it on the %target-swift-frontend mock SDK
commands. I ran into an issue with one of the PrintAsObjC tests that I am still
tracking down. I would rather just get this turned on to prevent further
regressions.
I also updated a few tests that needed some small tweaks to pass
this. Specifically:
Some parser tests needed some extra ossa insts to pass the verifier. This
doesn't effect what they actually test.
IRGen tests that should never have processed ossa directly. Today, we are
working towards a world where IRGen never processes [ossa] directly. Instead we
lower first. If/when that changes, we should add back in specific [ossa] tests.
A singular SILOptimizer definite init test case where the ownership verifier
fails due to a case which DI already flags as illegal (we just crash earlier). I
am going to look into fixing that by putting in errors in the typechecker or in
SILGen (not sure yet). I changed it to use target-swiftc_driver which does not
have ownership verification enabled.