[ParseableInterfaces] Preserve -enforce-exclusivity in interface args #23281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, we compile the standard library with `-enforce-exclusivity=unchecked`. If we don't preserve this argument, then the standard library compiled from an interface includes exclusivity enforcement, which pessimizes inlining those functions, which decreases performance for clients. Part of rdar://46431767
|
@swift-ci please smoke test |
|
"Thanks, I hate it." I guess if we ever change this behavior in the stdlib, it'll automatically update. It's unfortunate that we can't actually remove this option in the future, though; we'll have to ignore it instead. |
|
It's unfortunate, yeah. Alternatively, we could hard-code it on for the stdlib, but I don't like that either. |
|
No, I agree, this is the least bad thing. |
|
Linux failure: 🤔 |
|
@swift-ci please smoke test Linux platform |
harlanhaskins
pushed a commit
to harlanhaskins/swift
that referenced
this pull request
Mar 15, 2019
…swiftlang#23281) By default, we compile the standard library with `-enforce-exclusivity=unchecked`. If we don't preserve this argument, then the standard library compiled from an interface includes exclusivity enforcement, which pessimizes inlining those functions, which decreases performance for clients. Part of rdar://46431767
harlanhaskins
pushed a commit
that referenced
this pull request
Mar 18, 2019
…#23281) (#23344) By default, we compile the standard library with `-enforce-exclusivity=unchecked`. If we don't preserve this argument, then the standard library compiled from an interface includes exclusivity enforcement, which pessimizes inlining those functions, which decreases performance for clients. Part of rdar://46431767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we compile the standard library with
-enforce-exclusivity=unchecked. If we don't preserve this argument,then the standard library compiled from an interface includes
exclusivity enforcement, which pessimizes inlining those functions,
which decreases performance for clients.
Part of rdar://46431767